Python 2.7 #59
Merged
Python 2.7 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 15, 2018 23:46
|
@kcem thank you for the contribution. |
p1c2u
reviewed
Jul 28, 2018
|
|
||
| except ImportError: | ||
| from backports.functools_lru_cache import lru_cache | ||
| functools.lru_cache = lru_cache |
There was a problem hiding this comment.
I would like to avoid monkey patching.
| @@ -1,12 +1,28 @@ | |||
| """OpenAPI core validation util module""" | |||
| from yarl import URL | |||
| try: | |||
There was a problem hiding this comment.
Can be replaced with from six.moves.urllib.parse import urlparse
|
Thanks for merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made this changes because Python2.7 is still main Python in RHEL and many corporations are using it in they enterprise projects.
Sometimes people get new things (like OpenApi 3.0) and use it with old stuff (like Python2.7)