Skip to content

Fix MockRequest.body type #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 16, 2023

Commit 0031ff7 changed data from str to bytes, but forgot to adjust this default value.

Commit 0031ff7 changed data from str
to bytes, but forgot to adjust this default value.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46639b5) 91.20% compared to head (c59cbc5) 91.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         129      129           
  Lines        4129     4129           
  Branches      507      507           
=======================================
  Hits         3766     3766           
  Misses        296      296           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@p1c2u p1c2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, LGTM

@p1c2u p1c2u merged commit f62188b into python-openapi:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants