Skip to content

Conversation

TommasoPetrolito
Copy link

@TommasoPetrolito TommasoPetrolito commented Sep 10, 2025

I start from this issue/PR:
#1350
Trying to push again for this change to be merged/integrated, as people still face the issue/bug if this won't be merged.
In many projects I had to use the custom commits on forks to make it work, the discussion/conversation in PR 1350 shows that the issue is felt by a significant number of user and it would be nice to have this very little change finally merged @scanny

THE MODIFICATION IS:

The added code checks if self.target_ref exists and if it starts with a "#", which is a common way to denote external references. If both conditions are met, the method returns RTM.EXTERNAL, indicating that the target reference is external.

This change improves the robustness of our code by correctly handling and classifying external references. This will prevent potential errors or unexpected behavior when encountering such references.

Please merge this change now that the modification is properly aligned with latest code version and has no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant