Scale image size on insert #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for width and/or height to be passed into new_picture. This allows for any scaling to be applied to both the picture and its inline shape.
new_picture should be able to be called without specified width/height - they will just default to the native resolution of the given image.
|
This is fixed in version 0.8.2 released Feb 16, 2015. I took a somewhat different approach, but thanks very much for the PR Alecat, it was very helpful for thinking through how best to approach it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed: #94
Allow for width and/or height to be passed into new_picture.
This allows for any scaling to be applied to both the picture and its
inline shape.