Skip to content

Add support for limited abi, fixes #18 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add support for limited abi, fixes #18 #23

merged 1 commit into from
Jan 14, 2025

Conversation

timkpaine
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (2d21bf2) to head (2568897).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hatch_cpp/structs.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   95.71%   96.25%   +0.53%     
==========================================
  Files           7        7              
  Lines         257      294      +37     
==========================================
+ Hits          246      283      +37     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Test Results

6 tests  +1   6 ✅ +1   7s ⏱️ -2s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 2568897. ± Comparison against base commit 2d21bf2.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
hatch_cpp.tests.test_all ‑ test_import
hatch_cpp.tests.test_projects.TestProject ‑ test_basic[test_project_limited_api]
hatch_cpp.tests.test_structs.TestStructs ‑ test_validate_py_limited_api

♻️ This comment has been updated with latest results.

@timkpaine timkpaine force-pushed the tkp/lim branch 4 times, most recently from 7d9e7d0 to 8821067 Compare January 14, 2025 15:06
@timkpaine timkpaine merged commit 710091a into main Jan 14, 2025
15 checks passed
@timkpaine timkpaine deleted the tkp/lim branch January 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant