Add a __format__ implementation for Quantity #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes python-quantities#156 This fix is a slightly adapated version of yt-project/unyt@e57e1ec If we want to keep support for older versions of numpy we have to add a numpy version check. For simplicity I dropped support for older versions of numpy. I hope that this is fine.
|
@apdavison This PR is ready for a review now. Do you have an opinion on when we can remove support for older versions of numpy. I've just added a numpy version check to this PR to not break support for older versions of numpy, but it would be nice to drop support for older versions of numpy in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
This fix is a slightly adapted version of
yt-project/unyt@e57e1ec
If we want to keep support for older versions of numpy we have to add a
numpy version check. For simplicity I dropped support for older versions
of numpy. I hope that this is fine.
Edit: Added the numpy version check.