Skip to content

Fix numpy version string parsing #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

mscheltienne
Copy link
Contributor

The parsing added in the latest release does not work with development version and breaks MNE workflow here: mne-tools/mne-python#12815

https://github.com/mne-tools/mne-python/actions/runs/10577439355/job/29305416424#step:17:67

@apdavison apdavison merged commit 4e82387 into python-quantities:master Aug 27, 2024
39 checks passed
@apdavison
Copy link
Contributor

thanks for this. I'll wait a day or two to see if more bug reports for 0.16.0 come in, then release 0.16.1

@mscheltienne mscheltienne deleted the np2-fix branch August 27, 2024 13:33
@drammock
Copy link
Contributor

thanks for the quick fix @mscheltienne... curious why not switch to packaging.version.parse though? was it hesitation to add a dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants