Skip to content

Workflows with python-semantic-release broke on 03.05.22 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eifinger opened this issue May 3, 2022 · 17 comments · Fixed by #476
Closed

Workflows with python-semantic-release broke on 03.05.22 #442

eifinger opened this issue May 3, 2022 · 17 comments · Fixed by #476
Labels
bug Something isn't working properly

Comments

@eifinger
Copy link
Contributor

eifinger commented May 3, 2022

The problem

All my repo have a nightly scheduled workflow. I noticed that all which use this Github Action broke tonight. I struggle to find what the actual error is. Here is one example where the workflow broke: https://github.com/eifinger/hass-here-weather/runs/6267125839?check_suite_focus=true
I am running on the master branch so I think the latest commit broke something.

Expected behavior

The Github Action starts, checks commits, sees there is nothing to do and exits successfully.

Additional context

@eifinger eifinger added the bug Something isn't working properly label May 3, 2022
@martolini
Copy link

Experiencing the same issue, here.

@ngshiheng
Copy link

ngshiheng commented May 5, 2022

I dived a little bit deeper into this issue, and here's what I found:

@H0R5E
Copy link
Contributor

H0R5E commented May 17, 2022

EDIT: Removed pointless comment

I've pinned semantic release to version 7.28.1 as a workaround:

    - name: Python Semantic Release
      uses: relekang/python-semantic-release@v7.28.1
      with:
        github_token: ${{ secrets.GITHUB_TOKEN }}
        repository_username: __token__
        repository_password: ${{ secrets.PYPI_TOKEN }}

@SoundsSerious
Copy link

same here, not sure what to do about it besides downgrade

@SoundsSerious
Copy link

I can confirm @H0R5E's downgrade works

@sbrugman
Copy link

Same issue here. python-semantic-release picked up the version of another package that was linked in one of the commits.

@ajite
Copy link

ajite commented Jun 2, 2022

Same issue here. The downgrade worked.

@mrlubos
Copy link

mrlubos commented Jun 7, 2022

+1

@github-actions
Copy link

This bug report has been labelled as help wanted since there has been no activity in the last 3 weeks. It will not be closed.

@browniebroke
Copy link
Contributor

browniebroke commented Jul 14, 2022

I've pinned PSR to be <7.29 as well, but unfortunately this is also affected by the recent issue with packaging (#468). People in this thread were correct, it's a version parsing issue when one of the commits contain a version bump.

I think I fixed it in #472

Just tested it on one of my projects and it worked: https://github.com/browniebroke/deezer-oauth-cli/runs/7349125319?check_suite_focus=true#step%3A4%3A235=

EDIT: See below message. Although my fix worked in simple cases, it didn't work with a more recent version of PSR, and @eifinger fixed it.

@github-actions github-actions bot removed the help-wanted Extra attention is required label Jul 15, 2022
@ajite
Copy link

ajite commented Jul 19, 2022

@browniebroke thanks. I tried on it on one of my repo and it works.

@eifinger
Copy link
Contributor Author

I opened #476 to add the commit_subject functionality to @browniebroke work. I was using this feature and missing it.

You can use my action:

uses: eifinger/python-semantic-release@fix/ignore-deb-version-commits

I tested it on one of my projects:

https://github.com/eifinger/here_routing/runs/7449031696?check_suite_focus=true

@chanind
Copy link

chanind commented Jul 23, 2022

For some reason @browniebroke's fix didn't work for me. I had to branch off the 7.28.1 release and manually add the packaging fix in. In case it's useful for anyone else my fork can be used in a github action with uses: chanind/python-semantic-release@7-28-1-packaging-fix

@eifinger
Copy link
Contributor Author

eifinger commented Jul 23, 2022

@chanind what didn't work for you with my fix?

@chanind
Copy link

chanind commented Jul 23, 2022

I didn't try your version, I just tried browniebroke/python-semantic-release@fix/version-parsing-commit. You can see the output here, I'm not sure why it didn't work but it had the same issue with incorrectly parsing version from commits: https://github.com/chanind/fuzzy-reasoner/runs/7480887304?check_suite_focus=true

@browniebroke
Copy link
Contributor

Looks like it worked with @eifinger version: https://github.com/chanind/fuzzy-reasoner/runs/7480950131?check_suite_focus=true#step%3A4%3A244=

I'll close my PR and edit my comment to avoid confusion

@chanind
Copy link

chanind commented Jul 24, 2022

I didn't try the eifinger version - that link is using chanind/python-semantic-release@7-28-1-packaging-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
10 participants