Skip to content

feat: add pr linking to changelog #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Nov 10, 2024
Merged

feat: add pr linking to changelog #1091

merged 34 commits into from
Nov 10, 2024

Conversation

codejedi365
Copy link
Contributor

Purpose

Rationale

How did you test?

Added a brand new GitHubFlow repository that uses the squash commit strategy and used that fixture to ensure the default changelog generates PR/MR links. Also added unit tests to each parser to make sure they pulled out the various types of PR, MR syntax of the supported VCSs (BitBucket, GitHub, GitLab)

Note half of this PR has already been added to master by accident but I prevented it from being released. To see the full set of changes look from v9.12.2 to this HEAD

@codejedi365
test(changelog): fix errors in unit tests w/ changelog description pr…
2951644 
…inting
@codejedi365
refactor(parsers): define a ParsedMessageResult object type
c1ea6d6
@codejedi365
refactor(parser-angular): separate out message parsing vs commit parsing
5b64a38 
this will really help with improved e2e testing as we do not have a commit object
all the time. Besides this is just better to isolate commit object parsing when
we barely use the commit object.
@codejedi365
perf(parser-angular): simplify commit parsing type pre-calculation
a86a28c
@codejedi365
perf(parser-emoji): increase speed of commit parsing
2c9c468
@codejedi365
perf(parser-scipy): increase speed & decrease complexity of commit pa…
2b661ed 
…rsing
@codejedi365
fix(parsers): improve reliability of text unwordwrap of descriptions
436374b
@codejedi365
test(parser-scipy): fix tests to match the improved text unwrapping w…
eb45ca2 
…hen parsing
@codejedi365
fix(parser-angular): drop the breaking category but still maintain …
f1ffa54 
…a major level bump
@codejedi365
test(fixtures): refactor repo fixtures to simplify parsing & changelo…
154e5be 
…g generation
@codejedi365
test(cmd-version): update references matching new repo definition type
c259dfc
@codejedi365
test(fixtures): updating changelog generator for new autofit & commit…
f090a0b 
… definition
@codejedi365
fix(changelog-rst): ignore unknown parsed commit types in default RST…
77609b1 
… changelog
@codejedi365
refactor(changelog): harden macros to avoid attribute errors on Parse…
6d19402 
…dError commits
@codejedi365
test(fixtures): update repo fixtures to filter unknown commits & hand…
301fa44 
…le multi-line msgs
@codejedi365
test(changelog): update test implementations to match new repo defini…
68c236c 
…tions
@codejedi365
test(changelog): adjust ordering to make test filtering easier
00dc147
@codejedi365
test(fixtures): add & improve standardization of github flow repos
83eea1f
@codejedi365
refactor(changelog): remove extra newlines & spacing left behind
1093e90
@codejedi365
refactor(parser-angular): fix MR expression to capture extra leading …
4a8205e 
…whitespace
@codejedi365
refactor(parser-emoji): fix MR expression to capture extra leading wh…
86795b3 
…itespace
@codejedi365
test(fixtures): update common git repo fixtures to handle MRs in chan…
f29053d 
…gelogs
@codejedi365
test(fixtures): standardize naming of repo fixtures
920989b
@codejedi365
style(tests): update text formatting
79498ed
@codejedi365
test(cmd-changelog): add new github flow w/ squash strategy to change…
ff30818 
…log tests
@codejedi365
test(cmd-version): add new github flow w/ squash strategy to changelo…
6735f1b 
…g tests
@codejedi365
test(cmd-version): adjust parameterize ordering to make test filterin…
4475468 
…g easier
@codejedi365
test(fixtures): update git flow repo creation implementation
c1f7fa6
@codejedi365 codejedi365 self-assigned this Nov 10, 2024
@codejedi365 codejedi365 force-pushed the feat/add-pr-linking-to-changelog branch from 076d733 to 50b6a98 Compare November 10, 2024 03:46
@codejedi365
test(fixtures): fix version error on new github flow single release c…
1eab123 
…hannel repo
@codejedi365
test(fixtures): improve MD changelog generation relating to the 100 c…
0399db1 
…har wordwrap
@codejedi365
test(cmd-version): remove github flow repo from zero-dot test cases
c159bce 
because the versions are now bumped up to 1.0.0+ it is no longer
valid for running the zero-dot test cases against the github flow
repo with a feature channel. Will add it to the greater than zero
test cases
@codejedi365
test(cmd-changelog): improve resilency & drop unnecessary test cases …
3fede81 
…for no-op
@codejedi365
test(cmd-version): adjust to match w/ new version list of GitHubFlow …
aa4cf0e 
…multi-release channel repo
@codejedi365 codejedi365 force-pushed the feat/add-pr-linking-to-changelog branch from 50b6a98 to aa4cf0e Compare November 10, 2024 04:50
@codejedi365 codejedi365 merged commit aa4cf0e into python-semantic-release:master Nov 10, 2024
12 checks passed
@codejedi365 codejedi365 deleted the feat/add-pr-linking-to-changelog branch November 10, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@codejedi365 codejedi365

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to easily autolink to PRs in changelogs
1 participant
@codejedi365