fix(config): ensure default config loads on network mounted windows environments #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
Similar to the previous error with windows (#994), resolution must take place to make absolute paths and then be able to validate them against one another. I didn't previously run
resolve()on the found repo directory so it would display a symlink like alias of the home drive. When the changelog parents were evaluated, the changelog file was fully resolved to the network share that it represented, which caused the error to be thrown.How did you test?
The issue reporter tried the fix manually and it seemed to work. I modified our generate configuration tests to also load the configuration and run
semantic-release --noop --strict version --printwhich should load the configuration fully and then attempt to evaluate the repository. If any of that fails then it will throw an error. This way we will be able to detect a problem in the future on Windows in the CI, however, the CI does not have networked shares so it will be as close as we can get.