Feat/custom parser import #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26cbead to
ecd2e3e
Compare
…se_custom_parser`
…on for direct path imports Resolves: python-semantic-release#687
…ect path imports
ecd2e3e to
b89229c
Compare
🎉 This PR has been published as part of Version 9.16.0 🎉You can find more information about this release on the GitHub Releases page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
Due to python's import rules, its much harder to import a single file into the virtual environment and it doesn't make sense to build an entire separate project to disseminate a custom parser. This modification allows you to just store it in the current repository and then use a relative path to load it without any other installation steps.
How did you test?
I added addtional unit tests to verify importing of custom parsers via the file name. I did not write any e-2-e tests right now because i didnt feel it was necessary. But I did make sure it worked for the codejedi365/psr-monorepo-poweralpha example repository.