Skip to content

fix(parser-custom): handle relative parent directory paths to module file better #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix(parser-custom): handle relative parent directory paths to module file better #1142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/semantic_release/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ def dynamic_import(import_path: str) -> Any:
Dynamically import an object from a conventionally formatted "module:attribute"
string
"""
log.debug("Trying to import %s", import_path)
module_name, attr = import_path.split(":", maxsplit=1)

# Check if the module is a file path, if it can be resolved and exists on disk then import as a file
Expand All @@ -78,10 +77,11 @@ def dynamic_import(import_path: str) -> Any:
module_path = (
module_filepath.stem
if Path(module_name).is_absolute()
else str(Path(module_name).with_suffix("")).replace(os.sep, ".")
else str(Path(module_name).with_suffix("")).replace(os.sep, ".").lstrip(".")
)

if module_path not in sys.modules:
log.debug("Loading '%s' from file '%s'", module_path, module_filepath)
spec = importlib.util.spec_from_file_location(
module_path, str(module_filepath)
)
Expand All @@ -96,7 +96,9 @@ def dynamic_import(import_path: str) -> Any:

# Otherwise, import as a module
try:
log.debug("Importing module '%s'", module_name)
module = importlib.import_module(module_name)
log.debug("Loading '%s' from module '%s'", attr, module_name)
return getattr(module, attr)
except TypeError as err:
raise ImportError(
Expand Down
Loading