-
Notifications
You must be signed in to change notification settings - Fork 256
perf(logging): remove irrelevant debug logging statements #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
codejedi365
merged 2 commits into
python-semantic-release:master
from
codejedi365:fix/remove-excessive-logging
Jan 18, 2025
Merged
perf(logging): remove irrelevant debug logging statements #1147
codejedi365
merged 2 commits into
python-semantic-release:master
from
codejedi365:fix/remove-excessive-logging
Jan 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 This PR has been published as part of Version 9.17.0 🎉You can find more information about this release on the GitHub Releases page. |
1 task
1 task
This was referenced Jan 27, 2025
This was referenced Feb 5, 2025
This was referenced Feb 13, 2025
This was referenced Feb 22, 2025
Merged
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
It ends up most people run the CI in very verbose (
-vv
) mode because its hard to debug in an ephemeral environment. Unfortunately, PSR had some debug statements that really don't provide much value and end up just cluttering the output log. I got rid of those and then validated the rest of the logs messages are helpful and should be at the designated level or not.