config, version_variables: allow @ as separator and v to precede the version #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As discussed in #1156 and #846, this adds two features to the version_variables configuration:
E.g. when running psr with the following configuration
and there is a
my-versions.txt
with contentand the new version is
2.3.4
the content ofmy-versions.txt
will be:Rationale
Simple adaption of the regex did the trick
How did you test?
Unittesting was not easy as the implementation was entangled with other code. Therefore I did multiple commits:
Regarding the e2e tests: The tests are massive. I don't know where (and how i can expand those). I you point me to the right direction, i will add those tests.
How to Verify
The new documentation gives an example how to configure
PR Completion Checklist
Reviewed & followed the Contributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)