feat(parser-angular): add scope filtering option to Angular commit pa… #1216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Ensure Scope Filtering is Enforced Correctly
Resolves #1215
Purpose
This PR ensures that scope filtering logic is correctly applied when
allowed_scopes
is configured inConventionalCommitParserOptions
. Previously, commits without a scope were incorrectly bypassing the filtering, and commits with no allowed scopes defined were still being evaluated unnecessarily.Rationale
allowed_scopes
is not defined, the filtering logic should be skipped entirely to maintain the existing behavior.allowed_scopes
is defined, the commit must have a valid scope that is explicitly allowed.allowed_scopes
is configured.This change ensures a strict enforcement of scope filtering while keeping backwards compatibility when
allowed_scopes
is not set.How did you test?
Added unit tests to verify:
allowed_scopes
is enabled.allowed_scopes
definition behave as they currently do.Ran the test suite and verified that existing functionality remains unchanged for users who do not configure scope filtering.
How to Verify
pytest
to ensure all tests pass.ConventionalCommitParser
with different configurations:allowed_scopes
: Behavior remains unchanged.allowed_scopes
defined: Only commits with matching scopes should be allowed.allowed_scopes
is defined.PR Completion Checklist
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)