Skip to content

Version bump python-gitlab #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

xakepnz
Copy link
Contributor

@xakepnz xakepnz commented Apr 4, 2025

Purpose

The version of python-gitlab in this project was released ~October 2024. There's a lot of useful updates in the ~5 version, but it does drop support for the deprecated python3.8

Rationale

Projects utilising this dependency wish to use a later version of python-gitlab with python-semantic-release. Namely: https://gitlab.com/gitlab-security-oss/cis/gitlabcis

How did you test?

How to Verify


PR Completion Checklist

  • Reviewed & followed the Contributor Guidelines

  • Changes Implemented & Validation pipeline succeeds

  • Commits follow the Conventional Commits standard
    and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)

  • Appropriate Unit tests added/updated

  • Appropriate End-to-End tests added/updated

  • Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)

@codejedi365
Copy link
Contributor

We have a dependabot PR already for this dependency but it's blocked since the 3.8 deprecation. I have scheduled the 3.8 deprecation in #1078.

In the meantime, Are you actually using PSR's functionality as a library or can you use something like pipx to download into an isolated environment and run in your pipeline?

@codejedi365
Copy link
Contributor

Please remove the last test commit you have on this branch as that is incorrect in relation to this PR.

Given your second recommendation of just opening the requirement across the 5 version boundary is actually something I hadn't thought of. I think that will work best to still maintain 3.8 support for the time being.

@xakepnz
Copy link
Contributor Author

xakepnz commented Apr 7, 2025

We have a dependabot PR already for this dependency but it's blocked since the 3.8 deprecation. I have scheduled the 3.8 deprecation in #1078.

In the meantime, Are you actually using PSR's functionality as a library or can you use something like pipx to download into an isolated environment and run in your pipeline?

@codejedi365 Thanks - I've separated out the python-semantic-release dep install from the other optional dependency installs, so no more conflicts (using venv & Makefile).

@codejedi365
Copy link
Contributor

Thanks, will try to get this merged and published this week.

The primary change from `v4` to `v5` in this dependency was the removal of
identified support for `Python 3.8`.  Since we still support `Python 3.8`,
then we need to maintain the flexibility for 3.8 package managers to install
`v4` while allowing more modern projects to use the new features of `v5`
along side `python-semantic-release`.
@codejedi365
Copy link
Contributor

codejedi365 commented Apr 17, 2025

Closes PR #1207.

@codejedi365 codejedi365 merged commit a0cd1be into python-semantic-release:master Apr 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants