docs: Improved parsing of upstream branch name #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c50d09 to
40e6311
Compare
|
Thanks for the recommendation and fix |
40e6311 to
b564a48
Compare
🎉 This PR has been published as part of v10.4.1 🎉You can find more information about this release on the GitHub Releases page. |
fleetingbytes
added a commit
to fleetingbytes/ci-starter
that referenced
this pull request
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using renovate it may present branch names with additional "." (dots) in the branch name. This will break the upstream branch lookup. This updated version focuses on the 3 consecutive dots instead.
Purpose
Improve docs example on github CI pipeline, specifically on locating the upstream branch.
Rationale
When using renovate it may present branch names with additional "." (dots) in the branch name. This will break the upstream branch lookup. This updated version focuses on the 3 consecutive dots instead and selects the upstream branch name.
How did you test?
I changed the code in my own pipeline.
https://github.com/bartdorlandt/convert_poetry2uv/pull/44/files
How to Verify
Execute the old and new command on upstream branches, one with a "." in the name and one without.
PR Completion Checklist
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)