fix: prerelease tag in version patterns #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay construction of version and release patterns until runtime. This will allow to use non-default prerelease tag.
danth
reviewed
Jul 14, 2022
We actually had this exact issue in one of our uses. As the code currently stands, it is not possible to override the pre-release tag using cli flags and only works through changing it in the config files. The commit here appears to fix that issue since it does the check after init |
|
@saseith is right. Without this change, the "release_version_regex" and "version_regex" are assigned during the module import. Thus the "prerelease_tag" value used in the patterns will be the one available during the import time, which is before the runtime and before overwriting the config with values from the CLI. |
|
I see; will merge this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay construction of version and release patterns until runtime.
This will allow to use non-default prerelease tag.