Publish a new release on PyPi (2.9.0) #134

s-celles · 2019-05-29T15:39:18Z

Thanks to great work of @Flamefire we are now ready to publish a new release on PyPi

Here is a release procedure to follow
https://github.com/k-bx/python-semver/blob/master/release-procedure.md

but maybe we should have a discussion before about version numbering.

I don't really know if this new version should be named 2.8.2 or 2.9.0 (to respect semver)

Your opinions?

PS : I won't be available during the next coming days (until next week) so either @k-bx can publish or we can wait some days.

Flamefire · 2019-05-29T15:41:29Z

Although it is mostly a bugfix release (comparison was broken in last version) it contains a new feature: iterable

So it should be 2.9.0

pedrocunha · 2019-07-31T15:30:07Z

Hi - any plans to release a new version? The documentation does not match the available release on supporting comparison between VersionInfo objects and tuples. Thanks!

migueleliasweb · 2019-08-25T10:29:09Z

Hey all, any updates on this?

ofek · 2019-10-01T04:56:37Z

@k-bx Can you please upload a new release? Many of us are blocked on this 🙁

s-celles · 2019-10-01T06:05:01Z

Ideally I think the following PR should be merged before (#140 #138 and maybe #146)
We need a PR to prepare this release (see https://github.com/k-bx/python-semver/blob/master/release-procedure.md)
CHANGELOG at least should be updated (it haven't been updated since last release 2.8.1 (9 Jul 2018) which was see https://github.com/k-bx/python-semver/pulls?q=is%3Apr+is%3Aclosed
Contributions are always welcome!

tomschr · 2019-10-01T07:13:48Z

Maybe you want to have PR #147 included in the release as well. 😉

s-celles · 2019-10-30T14:44:51Z

Reopening because I don't understand what is going wrong.

I've tag a new release on Github but I facing an issue when trying to upload to Pypi

According my previous release procedure I should do:

git clean -xfd
python setup.py register sdist bdist_wheel --universal
twine upload dist/*

but this is what I'm getting:

$ python setup.py register sdist bdist_wheel --universal
running register
running egg_info
creating semver.egg-info
writing semver.egg-info/PKG-INFO
writing dependency_links to semver.egg-info/dependency_links.txt
writing entry points to semver.egg-info/entry_points.txt
writing top-level names to semver.egg-info/top_level.txt
writing manifest file 'semver.egg-info/SOURCES.txt'
reading manifest file 'semver.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'semver.egg-info/SOURCES.txt'
running check
warning: Check: This command has been deprecated. Use `twine check` instead: https://packaging.python.org/guides/making-a-pypi-friendly-readme#validating-restructuredtext-markup

warning: Check: The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 44: Error: Unknown interpreted text role "func".


Registering semver to https://upload.pypi.org/legacy/
Server response (410): Project pre-registration is no longer required or supported, upload your files instead.
WARNING: Registering is deprecated, use twine to upload instead (https://pypi.org/p/twine/)
running sdist
creating semver-2.8.2
creating semver-2.8.2/semver.egg-info
copying files to semver-2.8.2...
copying LICENSE.txt -> semver-2.8.2
copying MANIFEST.in -> semver-2.8.2
copying README.rst -> semver-2.8.2
copying semver.py -> semver-2.8.2
copying setup.cfg -> semver-2.8.2
copying setup.py -> semver-2.8.2
copying test_semver.py -> semver-2.8.2
copying semver.egg-info/PKG-INFO -> semver-2.8.2/semver.egg-info
copying semver.egg-info/SOURCES.txt -> semver-2.8.2/semver.egg-info
copying semver.egg-info/dependency_links.txt -> semver-2.8.2/semver.egg-info
copying semver.egg-info/entry_points.txt -> semver-2.8.2/semver.egg-info
copying semver.egg-info/top_level.txt -> semver-2.8.2/semver.egg-info
Writing semver-2.8.2/setup.cfg
creating dist
Creating tar archive
removing 'semver-2.8.2' (and everything under it)
running bdist_wheel
running build
running build_py
creating build
creating build/lib
copying semver.py -> build/lib
installing to build/bdist.macosx-10.9-x86_64/wheel
running install
running install_lib
creating build/bdist.macosx-10.9-x86_64
creating build/bdist.macosx-10.9-x86_64/wheel
copying build/lib/semver.py -> build/bdist.macosx-10.9-x86_64/wheel
running install_egg_info
Copying semver.egg-info to build/bdist.macosx-10.9-x86_64/wheel/semver-2.8.2-py3.7.egg-info
running install_scripts
adding license file "LICENSE.txt" (matched pattern "LICEN[CS]E*")
creating build/bdist.macosx-10.9-x86_64/wheel/semver-2.8.2.dist-info/WHEEL
creating 'dist/semver-2.8.2-py2.py3-none-any.whl' and adding 'build/bdist.macosx-10.9-x86_64/wheel' to it
adding 'semver.py'
adding 'semver-2.8.2.dist-info/LICENSE.txt'
adding 'semver-2.8.2.dist-info/METADATA'
adding 'semver-2.8.2.dist-info/WHEEL'
adding 'semver-2.8.2.dist-info/entry_points.txt'
adding 'semver-2.8.2.dist-info/top_level.txt'
adding 'semver-2.8.2.dist-info/RECORD'

I don't understanding why I'm still having 2.8.2 number and not 2.9.0

Any idea what is going wrong?

s-celles · 2019-10-30T14:49:38Z

Well the problem was that I was in my master... not k-bx/python-semver master but there is still a problem.

$ twine upload dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading semver-2.9.0-py2.py3-none-any.whl
100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 16.9k/16.9k [00:01<00:00, 9.27kB/s]
NOTE: Try --verbose to see response content.
HTTPError: 400 Client Error: The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information. for url: https://upload.pypi.org/legacy/

tomschr · 2019-10-30T14:59:05Z

@scls19fr

I think, your error messages is related to the CHANGELOG.rst file. That filename changed and the suffix .rst was added.

Probably the long_description_content_type key in setup.py is missing. See https://pypi.org/help/#description-content-type (taken from the error message. 😉 )

ofek · 2019-10-30T15:00:36Z

@scls19fr and in https://github.com/k-bx/python-semver/blob/master/README.rst you can't use Sphinx directives

s-celles · 2019-10-30T15:03:12Z

@tomschr long_description_content_type is only necessary for not rst file (ie when using for example Markdown).

@ofek is right... see #171

Flamefire · 2019-10-30T15:07:20Z

Maybe easier: Use Markdown?

tomschr · 2019-10-30T15:09:52Z

Maybe easier: Use Markdown?

The CHANGELOG.rst file can't be included into the doc anymore (well, actually you can, but it would be a bit more cumbersome).

tomschr · 2019-10-30T15:15:39Z

@ofek is right... see #171

Oh really? I wasn't aware of that. Strange that PyPI seems to have problems with this. Couldn't they just ignore the :func: directive?

s-celles · 2019-10-30T15:16:53Z

Maybe you can ask them (opening an issue on their side if it doesn't exist)

s-celles · 2019-10-30T15:31:14Z

It seems that 2.9.0
is now available on https://pypi.org/project/semver/

can't understand why doc is still numbered as 2.8.2
https://python-semver.readthedocs.io/en/latest/

s-celles · 2019-10-30T15:42:10Z

Doc build wasn't passing correctly.
Now it's fine https://python-semver.readthedocs.io/en/latest/

tomschr · 2019-10-30T15:43:28Z

@scls19fr Thanks you for all your efforts! 👍

s-celles · 2019-10-30T15:46:06Z

Thanks all! I think we still need to improve the release procedure to have smoother release.
#173

Automatic build of doc should also be on our top 1 priority list (#95)

tomschr · 2019-10-30T15:47:54Z

I think we still need to improve the release procedure to have smoother release.

Maybe Git Actions could help? See https://github.com/marketplace/actions/deploy-pypi or https://github.com/marketplace/actions/pypi-publish for a PyPI action.

Here is more: https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

s-celles · 2019-10-30T16:01:27Z

Yes but I haven't try it myself.

tomschr · 2019-10-30T16:06:08Z

Maybe I can try something, but it takes some time.

tomschr · 2019-10-31T10:44:53Z

@scls19fr I've created a GitHub Action for my forked repo. Seems it works for me. 😉

Pull Request
First GitHub Action to test for test.pypi.org tomschr/python-semver#1
See the GitHub Action
https://github.com/tomschr/python-semver/commit/e82151e7fccb56524d3644b64fd1d22c04380005/checks?check_suite_id=289701678

If you want to use it, you need to do these steps:

Enable/register/whatever these GitHub Actions for your repo.
Add your secrets for PyPI.org and test.pypi.org to your GitHub settings > Secrets.
Keep in mind, the names must be test_pypi_password and pypi_password.
Remove the comments in .github/workflow/publish-to-test-pypi.yml (should we use a better name?)

I've followed mostly the examples mentioned in #134 (comment).

If you like it, I can open a PR for this repo.

Let me know what you think. 😉

s-celles · 2019-10-31T10:49:58Z

I haven't access to "settings" in this repository.
I think we should either ask @k-bx to do it or fork this repository in a GitHub organization where we could do that.
@tomschr @k-bx what are your opinions?

tomschr · 2019-10-31T15:51:56Z

@scls19fr
Thanks for your response and for asking about my opinion. 😊 I'm not sure if I can be of any value to this issue, so I'm fine with whatever you decide.

These GitHub Actions, once enabled, can be basically changed by everyone with a simple pull request (it's just the .github/workflow/ directory).

s-celles · 2019-10-31T15:59:33Z

I've created https://github.com/python-semver GH org and sent an invite to @k-bx to be an owner.
I'm waiting for an answer before going beyond.

k-bx · 2019-11-01T12:29:46Z

Hey, sure, feel free to move into an organization. Also, please ping me by my email directly if I'm needed, I'm rarely reading the github issues.

tomschr · 2019-11-02T14:19:01Z

@scls19fr @k-bx Maybe you know that already so sorry to bother. With a GitHub organization you can group trusted members into different teams which different permissions (an author team has write/push permission, but cannot change admin settings, but an admin team can).

This may be a start:

s-celles · 2019-11-03T18:47:47Z

Hi all,

Thanks @k-bx for accepting the idea of a GH org.
This should greatly help collective maintenance work on python-semver!

In order to keep issues history, I think you will need to transfer ownership of https://github.com/k-bx/python-semver to https://github.com/python-semver/ Github org.

https://help.github.com/en/github/administering-a-repository/transferring-a-repository#transferring-a-repository-owned-by-your-user-account

Kind regards

ppkt mentioned this issue Oct 3, 2019

Python Support for Batch File is Wrong #153

Closed

s-celles mentioned this issue Oct 30, 2019

Release 2.9.0 #170

Merged

s-celles closed this as completed in #170 Oct 30, 2019

s-celles reopened this Oct 30, 2019

s-celles changed the title ~~Publish a new release on PyPi~~ Publish a new release on PyPi (2.9.0) Oct 30, 2019

s-celles mentioned this issue Oct 30, 2019

Fix long description #171

Closed

s-celles closed this as completed Oct 30, 2019

s-celles mentioned this issue Nov 3, 2019

Move k-bx/python-semver to python-semver/python-semver / transfer ownership of k-bx/python-semver to python-semver Github organization #177

Closed

Publish a new release on PyPi (2.9.0) #134

Publish a new release on PyPi (2.9.0) #134

Comments

s-celles commented May 29, 2019

Flamefire commented May 29, 2019

Uh oh!

pedrocunha commented Jul 31, 2019

Uh oh!

migueleliasweb commented Aug 25, 2019

Uh oh!

ofek commented Oct 1, 2019

Uh oh!

s-celles commented Oct 1, 2019

Uh oh!

tomschr commented Oct 1, 2019

Uh oh!

s-celles commented Oct 30, 2019

Uh oh!

s-celles commented Oct 30, 2019

Uh oh!

tomschr commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ofek commented Oct 30, 2019

Uh oh!

s-celles commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Flamefire commented Oct 30, 2019

Uh oh!

tomschr commented Oct 30, 2019

Uh oh!

tomschr commented Oct 30, 2019

Uh oh!

s-celles commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s-celles commented Oct 30, 2019

Uh oh!

s-celles commented Oct 30, 2019

Uh oh!

tomschr commented Oct 30, 2019

Uh oh!

s-celles commented Oct 30, 2019

Uh oh!

tomschr commented Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s-celles commented Oct 30, 2019

Uh oh!

tomschr commented Oct 30, 2019

Uh oh!

tomschr commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s-celles commented Oct 31, 2019

Uh oh!

tomschr commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s-celles commented Oct 31, 2019

Uh oh!

k-bx commented Nov 1, 2019

Uh oh!

tomschr commented Nov 2, 2019

Uh oh!

s-celles commented Nov 3, 2019

Uh oh!

tomschr commented Oct 30, 2019 •

edited

Loading

s-celles commented Oct 30, 2019 •

edited

Loading

s-celles commented Oct 30, 2019 •

edited

Loading

tomschr commented Oct 30, 2019 •

edited

Loading

tomschr commented Oct 31, 2019 •

edited

Loading

tomschr commented Oct 31, 2019 •

edited

Loading