Skip to content

Improve GH Action for Black to use --check #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomschr opened this issue Nov 25, 2019 · 0 comments
Closed

Improve GH Action for Black to use --check #203

tomschr opened this issue Nov 25, 2019 · 0 comments
Assignees
@tomschr
Labels
Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness Infra All about infrastructure (GitHub Action, project build etc.)

Comments

@tomschr
Copy link
Member

tomschr commented Nov 25, 2019

Situation

Originally posted by @ppkt in #200 (comment):

I know it's already merged but I have an idea - maybe instead of formatting code base and uploading .diff file, this action should only check whether code is formatted (i.e. exit code from black is 0 - see option --check)?

Proposed Solution

  • Remove diff creation
  • Add option --check
@tomschr tomschr added Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness Infra All about infrastructure (GitHub Action, project build etc.) labels Nov 25, 2019
@tomschr tomschr self-assigned this Nov 25, 2019
tomschr added a commit to tomschr/python-semver that referenced this issue Nov 25, 2019
@tomschr
Fix python-semver#203: Use --check option for black (infra)
3a68ebd 
* Remove uploading the diff file as artifact
* Use `--check` to test our source code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomschr tomschr

Labels
Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness Infra All about infrastructure (GitHub Action, project build etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomschr