Fix #251: Correct return type for next_version() #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # semver.py
…ility function for check the validity of the index.
…w useless _validate_index.
Co-Authored-By: Tom Schraitle <tomschr@users.noreply.github.com>
� Conflicts: � test_semver.py
# Conflicts: # semver.py # test_semver.py
|
PS: you might want to squash these commits since I merged newer changes from the repo into my old fork |
|
@tlaferriere haha, we had the same idea. 😄 I've created #255. There is one thing you could improve: Could you copy the CHANGELOG from my PR? You should also adapt the PR number to this. Other than that, it looks ok. I will squash the commits later. |
|
I was just about to do that |
tomschr
reviewed
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomschr if you could take a look that would be appreciated.