Skip to content

Describe Pydantic and semver in "Advanced topics" #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

Describe Pydantic and semver in "Advanced topics" #353

merged 1 commit into from
Jan 28, 2022

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Jan 27, 2022

This PR adds a new section into "Advanced topic". Fixing #343.

@calebstewart would you mind having a look? Anything that is missing, wrong, or could be done better? Would be really helpful. Thank you very much! ❤️

@tomschr tomschr self-assigned this Jan 27, 2022
@tomschr tomschr added the Doc Documentation related issue label Jan 27, 2022
@tomschr tomschr mentioned this pull request Jan 27, 2022
Closed
@tomschr
Copy link
Member Author

tomschr commented Jan 28, 2022

If you don't object, I will merge it to master tomorrow. 🙂

@calebstewart
Copy link
Contributor

I just double checked the code. My only note is that the __get_validators__ method should be yield cls.parse instead of yield cls.pars. Just a missing e.

Aside from that, the examples work, and make sense to me! Thanks for checking in with me! I appreciate it!

@tomschr tomschr force-pushed the feature/343-pydantic-into-doc branch from 4d2bffa to c7a6a9e Compare January 28, 2022 16:18
@tomschr
Copy link
Member Author

tomschr commented Jan 28, 2022

I just double checked the code. My only note is that the __get_validators__ method should be yield cls.parse instead of yield cls.pars. Just a missing e.

Ahh, good catch! 👍 Thanks for the hint, I've already fixed it.

Aside from that, the examples work, and make sense to me! Thanks for checking in with me! I appreciate it!

Thank you! I've added you as a co-author. 🙂

@tomschr @calebstewart
Describe Pydantic and semver in "Advanced topics"
73bd190 
Related to issue python-semver#343

Co-authored-by: Caleb Stewart <calebstewart@users.noreply.github.com>
@tomschr tomschr force-pushed the feature/343-pydantic-into-doc branch from c7a6a9e to 73bd190 Compare January 28, 2022 16:21
@tomschr tomschr merged commit bafd212 into python-semver:master Jan 28, 2022
@tomschr tomschr deleted the feature/343-pydantic-into-doc branch January 28, 2022 16:27
@tomschr
Copy link
Member Author

tomschr commented Jan 28, 2022

The documentation is now available at https://python-semver.readthedocs.io/en/latest/advanced/combine-pydantic-and-semver.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomschr tomschr

Labels
Doc Documentation related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomschr @calebstewart