Remove incorrect dependencies from build-system section of pyproject.toml #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the redundant `wheel` dependency, as it is added by the backend automatically. Listing it explicitly in the documentation was a historical mistake and has been fixed since, see: pypa/setuptools@f7d30a9
Remove the dependency on `build` that is irrelevant to backend dependencies. `build` is one of the PEP517 frontends, and as such it needs to be installed on the system starting PEP517 build rather than inside the virtual environment used to perform the builds.
|
@mgorny Thanks for your contribution! Much appreciated! 👍 This was a remnant from Python 3.6. I've also updated If you are okay with it, I can merge it. |
mgorny
commented
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
wheelandbuilddependencies frompyproject.toml. The former is added automatically by setuptools and is incorrect for sdist, the latter is frontend rather than backend.(described in detail in commit messages)