Skip to content

[FEATURE] Enter missing defaults at runtime #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Poolitzer opened this issue Oct 2, 2019 · 1 comment · Fixed by #1490
Closed

[FEATURE] Enter missing defaults at runtime #1527

Poolitzer opened this issue Oct 2, 2019 · 1 comment · Fixed by #1490
Assignees
@Bibo-Joshi

Comments

@Poolitzer
Copy link
Member

Poolitzer commented Oct 2, 2019 •
edited
Loading

This was an idea we had in mind (and discussed) somewhere a while back. Users should be able to pass defaults to a convenient method, so all the requests to the bot API which have this paramater defaults to the one the user provided. Examples would be parse mode, disable notification, hide link preview. This shall be edited with a sufficient list of parameters and where exactly we want to implement this (updater, dispatcher, bot instance?) in the future, this is merely a reminder for now.
@Poolitzer Poolitzer mentioned this issue Oct 10, 2019
Merged
@Poolitzer Poolitzer changed the title Enter defaults at runtime Enter missing defaults at runtime Oct 10, 2019
@Poolitzer
Copy link
Member Author

So, the referred PR is implementing parse_mode as a default option. This issue will track its succesfull implementing secondarly, but primarly will stay up to track the implementing of other defaults we want to have. Current list:

  • parse mode
  • timeout
  • disable notification
  • hide link preview

@Poolitzer Poolitzer added this to the 12.3 milestone Oct 10, 2019
@Bibo-Joshi Bibo-Joshi self-assigned this Oct 17, 2019
@jh0ker jh0ker changed the title Enter missing defaults at runtime [FEATURE] Enter missing defaults at runtime Oct 25, 2019
@Bibo-Joshi Bibo-Joshi mentioned this issue Oct 27, 2019
Closed
@Bibo-Joshi Bibo-Joshi removed this from the 12.4 milestone Jan 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Bibo-Joshi Bibo-Joshi

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Bibo-Joshi @Poolitzer