Skip to content

drop python2 support #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
14 tasks
Poolitzer opened this issue Oct 10, 2019 · 8 comments
Closed
14 tasks

drop python2 support #1538

Poolitzer opened this issue Oct 10, 2019 · 8 comments
Assignees
@jh0ker
Labels
📋 help-wanted work status: help-wanted

Comments

@Poolitzer
Copy link
Member

Poolitzer commented Oct 10, 2019 •
edited by Bibo-Joshi
Loading

That means to remove it from:

  • README.rst
  • CONTRIBUTING.rst
  • .pre-commit-config.yaml
  • .travis.yml
  • appveyor.yml
  • setup.py
  • tox.ini
  • all tests (hihi)

We can even think about dropping all the python2 workarounds we have in the library itself:

  • remove future from requirements and all the imports
  • _UTC in telegram.utils.helpers
  • Workaround in telegram.InputFile.__init__()
  • from builtins import str in telegram.utilts.request
  • test_send_on_server_emoji
  • imports in test.updater

(This list is not comprehensive)
@Poolitzer Poolitzer added this to the 13.0 milestone Oct 10, 2019
@Poolitzer Poolitzer added enhancement 📋 help-wanted work status: help-wanted labels Oct 10, 2019
@jh0ker
Copy link
Member

jh0ker commented Oct 10, 2019

We can even think about dropping all the python2 workarounds we have in the library itself.

Arguably the most important part

@Poolitzer Telegram GithubBot Revised
Copy link
Member Author

@jh0ker funny how you write the most work required part. But yes. We should.

@jh0ker jh0ker mentioned this issue Oct 11, 2019
Closed
@Bibo-Joshi
Copy link
Member

Took the liberty to add some ToDos to the description ;) We can update that list, if we stumble across some workaround while coding something else …

@Poolitzer Poolitzer mentioned this issue Jan 1, 2020
Closed
@septatrix
Copy link
Contributor

Hey, if possible I would like to work on this.
I already started a bit and would create a WIP merge request tomorrow...

@Bibo-Joshi
Copy link
Member

Sure, please go ahead :)

@septatrix septatrix mentioned this issue Jan 19, 2020
Merged
@septatrix
Copy link
Contributor

Pull request is now live #1715...

@Bibo-Joshi Bibo-Joshi mentioned this issue Jan 23, 2020
Closed
@Poolitzer
Copy link
Member Author

Poolitzer commented Jan 26, 2020 •
edited
Loading

#1731 removed 2.7 from the workflow to reduce testing time

#1734 removed 2.7 from public endpoints in order to reduce confusion about supported versions of this library

@septatrix septatrix mentioned this issue Jan 31, 2020
Closed
@Bibo-Joshi Bibo-Joshi removed this from the 13.0 milestone Jun 11, 2020
@Bibo-Joshi
Copy link
Member

Closed by #1715

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jh0ker jh0ker

Labels
📋 help-wanted work status: help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jh0ker @Bibo-Joshi @septatrix @Poolitzer