Skip to content

[FEATURE] Add _id_attrs #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Jan 17, 2020 · 1 comment · Fixed by #1724
Closed

[FEATURE] Add _id_attrs #1708

Bibo-Joshi opened this issue Jan 17, 2020 · 1 comment · Fixed by #1724
Assignees
@Bibo-Joshi

Comments

@Bibo-Joshi
Copy link
Member

Is your feature request related to a problem? Please describe.

InlineKeyboardMarkup and InlineKeyboardButton objects are currently not really testable for equality because the _id_attrs are not set. We should add all attributes of IKB to the _id_attr and inline_keyboard for IKM.

Additional context

We already did that for MessageEntity iirc. Probably should go through the lib and do that for all the telegram objects.

Current workaround

Use __dict__ for everything
@Bibo-Joshi Bibo-Joshi self-assigned this Jan 17, 2020
@Bibo-Joshi Bibo-Joshi mentioned this issue Jan 23, 2020
Merged
4 tasks
@Bibo-Joshi
Copy link
Member Author

#1724 has been merged into v13, so I'll close

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Bibo-Joshi Bibo-Joshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make (most) objects comparable python-telegram-bot/python-telegram-bot
1 participant
@Bibo-Joshi