Skip to content

Check if we can be smarter about start_webhook #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bibo-Joshi opened this issue Mar 4, 2021 · 0 comments · Fixed by #2419
Closed

Check if we can be smarter about start_webhook #2416

Bibo-Joshi opened this issue Mar 4, 2021 · 0 comments · Fixed by #2419
Labels
🛠 refactor change type: refactor

Comments

@Bibo-Joshi
Copy link
Member

More precisely, check if we can call set_webhook automatically in more cases. Things to consider:

  1. As of API 5.0 we have the drop_pending_updates parameter, so we can handle the clean logic more elegantly
  2. SSL-settings can be applicable at two different "positions": the URL where TG sends the updates to and the webhookserver, where we fetch them. those two are not necessarily the same (e.g. reverse proxy)
  3. citing jannes: "I think we could use the cert to set the webhook if available, but only use it for SSL termination if there is also a key provided" (which needs to be double checked)
@Bibo-Joshi Bibo-Joshi added enhancement 🛠 refactor change type: refactor labels Mar 4, 2021
@Bibo-Joshi Bibo-Joshi mentioned this issue Mar 6, 2021
6 tasks
@Poolitzer Poolitzer changed the title Ceck if we can be smarter about start_webhook Check if we can be smarter about start_webhook Mar 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 refactor change type: refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant