-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Closed
Labels
🛠 breakingchange type: breakingchange type: breaking🛠 refactorchange type: refactorchange type: refactor
Milestone
Description
There are some TG classes that are used for input only, but where we still accept kwargs - which is mainly intended for the classes that we de-json TG data. This sometimes leads to confusion like here https://t.me/pythontelegrambotgroup/503803 b/c additional arguments are silently ignored.
This is somehow the same problem as in #1924.
I see three possible ways to proceed with this:
- keep
**kwargs
and do nothing - Drop
**kwargs
for classes that are exclusively used for input. This has a minor risk of TG actually sending them back to us at some point … - keep
**kwargs
but issue warnings when receiving unexpected arguments
I think we should at least try to apply any of the solutions consistently - not sure if that's currently the case.
Metadata
Metadata
Assignees
Labels
🛠 breakingchange type: breakingchange type: breaking🛠 refactorchange type: refactorchange type: refactor