Skip to content

[BUG] v14: _BaseMedium shouldn't have bot as a slot #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
harshil21 opened this issue Mar 7, 2022 · 0 comments
Closed

[BUG] v14: _BaseMedium shouldn't have bot as a slot #2921

harshil21 opened this issue Mar 7, 2022 · 0 comments
Milestone
v20.0a0

Comments

@harshil21
Copy link
Member

harshil21 commented Mar 7, 2022 •
edited
Loading

Steps to Reproduce

  1. Check slots of _BaseMedium.
  2. accessing bot in any instance of _BaseMedium would lead to an error since that is not used. We use _bot.

Expected behaviour

bot should be removed from the slot.

Actual behaviour

Operating System

Version of Python, python-telegram-bot & dependencies

PTB v14

Relevant log output

No response

Additional Context

test_slot_behaviour passes for PhotoSize since we don't explicitly have a test for its superclass (_BaseMedium).

Will be fixed in #2893
@harshil21 harshil21 added this to the v14 milestone Mar 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v20.0a0
Development

No branches or pull requests
2 participants
@Bibo-Joshi @harshil21