Skip to content

[Documentation] Add note on editing with reply markups #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Bibo-Joshi opened this issue Jun 21, 2022 · 3 comments
Closed

[Documentation] Add note on editing with reply markups #3111

Bibo-Joshi opened this issue Jun 21, 2022 · 3 comments
Labels
⚙️ documentation affected functionality: documentation ℹ️ good-first-issue information: good-first-issue

Comments

@Bibo-Joshi
Copy link
Member

We should add note to all Bot.edit_* methods that states the limitation about editing messages from the official docs:

Please note, that it is currently only possible to edit messages without reply_markup or with inline keyboards.

This should be done via the Note: role of sphinx as done e.g. here

A contribution in this direction is very welcome! A PR for this should be made against the doc-fixes branch. Please also check out the contribution guide, especially the part on how to build the documentation locally.
@Bibo-Joshi Bibo-Joshi added ℹ️ good-first-issue information: good-first-issue ⚙️ documentation affected functionality: documentation labels Jun 21, 2022
@Bibo-Joshi Bibo-Joshi mentioned this issue Jun 21, 2022
Closed
24 tasks
@ExalFabu ExalFabu mentioned this issue Jun 25, 2022
Merged
@abhinav1912
Copy link

As a first contribution, this seems like a manageable task. Should I pick this?

@Bibo-Joshi
Copy link
Member Author

Hi, thanks for your interest! Someone already PRed for this issue - see #3121. But #3110 and #3109 are possible alternatives :)

@Bibo-Joshi
Copy link
Member Author

closed by #3121

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
⚙️ documentation affected functionality: documentation ℹ️ good-first-issue information: good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bibo-Joshi @abhinav1912