Skip to content

All api 4.2 and 4.3 changes #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 23, 2019
Merged

All api 4.2 and 4.3 changes #1418

merged 6 commits into from
Aug 23, 2019

Conversation

Eldinnie
Copy link
Member

@Eldinnie Eldinnie commented Jun 6, 2019

Tests and coverage check needed

Eldinnie and others added 6 commits June 5, 2019 15:00
actually works now

Add tests

Fix flake8 issues.

Add poll argument to Update.

Fix pre-commit config
Finalizing 4.2

No notify on pin
Add LoginUrl to InlineKeyboardButton

Add reply_markup to message
@AyraHikari
Copy link

Hello, i test that branch, and starting editing my bot script for future update.
But i got an error:

Traceback (most recent call last):
  File "/home/ayra/bot/my/__main__.py", line 535, in process_update
    handler.handle_update(update, self)
TypeError: handle_update() missing 1 required positional argument: 'check_result'

My script is

for handler in (x for x in self.handlers[group] if x.check_update(update)):
                handler.handle_update(update, self)
                break

I don't know what check_result is mean, when i'm insert check_result="test", bot is not responding when i send a command /start.

Also there is no guide for that in this guide.

Thank you

@Eldinnie
Copy link
Member Author

ehm...
Why do you run this? Choosing which handler is/and ashould be done by the dispatcher. It might be helpfull if you shared all your code and the intention of what you;re trying to do.

@AyraHikari
Copy link

Sure, here it is

Copy link
Member Author

@AyraHikari you rewrote the dispatchers process_update method. If you want to do that with the new version, you will have to make sure it works the same as Dispatcher.process_update.

@AyraHikari
Copy link

Oh i see, maybe i should rewrite all things since many of that deprecated.
Thank you for your response. Sorry for late reply

@TheHolyLoli
Copy link

why is this not merged?

@Nukesor
Copy link

Nukesor commented Jul 31, 2019

Would love to see this merged, especially since 4.4 is already out there!

This was referenced Aug 4, 2019
@Bibo-Joshi
Copy link
Member

I noticed, that an telegram.loginurl.rst file is missing for the docs.

@tsnoam tsnoam merged commit ac60d05 into master Aug 23, 2019
@Nukesor Nukesor mentioned this pull request Aug 23, 2019
6 tasks
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 8, 2020
18 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants