Added file_unique_id attrs from API 4.5 and updated tests for it #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bibo-Joshi could you help me with these changes? |
|
Thanks for the PR! I'll check everything, might take a few days. |
|
Sorry for the delay, but I checked all the tests and used flake8 in the last commit. Could you check the tests and changes in both commits together. |
Bibo-Joshi
requested changes
Jan 8, 2020
This comment has been minimized.
This comment has been minimized.
|
@Bibo-Joshi required changes has been done. I'm waiting for next steps. :) |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last changes for #1689 issue.
WARNING: This is just a commit to send the code! Changes are not checked and not launched.
Could you please review, spell check and run tests regarding committed changes?