Skip to content

improve CI #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2020
Merged

improve CI #1716

merged 1 commit into from
Jan 26, 2020

Conversation

Poolitzer
Copy link
Member

@Poolitzer Poolitzer commented Jan 20, 2020 •
edited
Loading

closes #1700

Okay, to explain what happens: Official test always looks like its work, even though it fails (see https://github.community/t5/GitHub-Actions/continue-on-error-allow-failure-UI-indication/td-p/37033)

I haven't tested the push event, but it should work.
Edit: Tested, works.

@Poolitzer Poolitzer changed the title on push test, official can fail improve CI Jan 20, 2020
@Poolitzer Poolitzer added the 📋 pending-review work status: pending-review label Jan 20, 2020
@Poolitzer Poolitzer added this to the 12.4 milestone Jan 20, 2020
@tsnoam tsnoam merged commit d2466f1 into master Jan 26, 2020
@tsnoam tsnoam deleted the improve-workflow branch January 26, 2020 20:07
@Poolitzer Poolitzer mentioned this pull request Mar 10, 2020
Merged
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsnoam tsnoam tsnoam approved these changes

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
📋 pending-review work status: pending-review
Projects
None yet
Milestone
12.4
Development

Successfully merging this pull request may close these issues.

[BUG] CI: check master after merge
3 participants
@Poolitzer @tsnoam @Bibo-Joshi