Skip to content

Type hinting added for properties of Update object #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Type hinting added for properties of Update object #1767

wants to merge 1 commit into from

Conversation

igorsereda
Copy link

No description provided.

@Bibo-Joshi
Copy link
Member

Hi. Thanks for the PR :)

However, I fear that if we want to add type hinting, it should be done for everything at once. I.e. maybe not in a single PR, but at least we should work on a dedicated branch and then merge to master. Therefore, I'll be closing this for now.

If you feel like starting on adding type hinting for the entire library (you are very welcome!), I suggest to comment on #1373 to make sure we're in sync on how we approach this.

@Bibo-Joshi Bibo-Joshi closed this Feb 20, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants