Skip to content

Reorder 2 bot tests to make them pass #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

Reorder 2 bot tests to make them pass #1835

merged 1 commit into from
Mar 30, 2020

Conversation

artemrys
Copy link
Contributor

I have tested this locally, worked for me.
Per #1826 (comment), I am creating a PR to see if it is OK in CI.

Explanation: #1759 (comment)

@artemrys artemrys marked this pull request as ready for review March 19, 2020 00:11
@artemrys artemrys changed the title Reorder 2 bot tests to make it pass Reorder 2 bot tests to make them pass Mar 19, 2020
Poolitzer
Poolitzer approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes make sense. LGTM

@Bibo-Joshi Bibo-Joshi merged commit d55d981 into python-telegram-bot:master Mar 30, 2020
@Bibo-Joshi
Copy link
Member

Thank you for you contribution!

@artemrys artemrys deleted the feature/flaky-tests-investigation branch March 30, 2020 20:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemrys @Bibo-Joshi @Poolitzer