Skip to content

Use @abstractmethod instead of rasing NotImplementedError #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2020
Merged

Use @abstractmethod instead of rasing NotImplementedError #1905

merged 1 commit into from
May 1, 2020

Conversation

Bibo-Joshi
Copy link
Member

Closes #1837

This is more of a proposal, as I recall @tsnoam not being fond of ABC.

@Bibo-Joshi Bibo-Joshi requested a review from tsnoam April 19, 2020 14:18
Poolitzer
Poolitzer approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd wait for @tsnoam to say smth about this

@tsnoam tsnoam merged commit 632b989 into master May 1, 2020
@tsnoam tsnoam deleted the use-abc branch May 1, 2020 18:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

@tsnoam tsnoam Awaiting requested review from tsnoam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use @abstractmethod inside of abstract classes
3 participants
@Bibo-Joshi @Poolitzer @tsnoam