UPG: Remove future from requirements and all the imports (#1538) #1944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for the PR. @septatrix already has a big PR open for Py2 removal (#1715). Can you maybe check, if your changes are already covered by that? Also please note, that it will probably take a whole while until we come around to dropping Py2 from the code base. Regardless of that: All the tests are failing. You can run the tests suite locally by |
|
I saw his previous PRs, but unfortunately not all) I just started checking files from the repository. Yes, a lot of fails. But mainly because of the "future" in tests. I will try to find errors and fix them. |
|
All of what you implemented should already be included in my PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Hope to help. Ready for comments.