Skip to content

Defaults.tzinfo #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Sep 27, 2020
Merged

Defaults.tzinfo #2042

merged 39 commits into from
Sep 27, 2020

Conversation

Bibo-Joshi
Copy link
Member

Adds Defaults.tzinfo so that all naive date/time inputs are interpreted as a specified timezone.
Only handles pytz-timezones, as that's pretty much the standard-lib for that and APScheduler also only handles pytz.

Closes #1797

@Bibo-Joshi
Temporarily enable tests for the v13 branch
f43ede1
@Bibo-Joshi
Refactor handling of kwargs in Bot methods (#1924)
8e9938d 
* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods
@Bibo-Joshi
Refactor JobQueue (#1981)
176d221 
* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

# Was intended for interal use anyways
# Fixes tests

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue
@Bibo-Joshi
Refactor persistence of Bot instances (#1994)
543440a 
* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation
@Bibo-Joshi
Extend rich comparison of objects (#1724)
7867b9b 
* Make most objects comparable

* ID attrs for PollAnswer

* fix test_game

* fix test_userprofilephotos

* update for API 4.7

* Warn on meaningless comparisons

* Update for API 4.8

* Address review

* Get started on docs, update Message._id_attrs

* Change PollOption & InputLocation

* Some more changes

* Even more changes
@Bibo-Joshi
Refactor handling of default_quote (#1965)
8e94d0d 
* Refactor handling of `default_quote`

* Make it a breaking change

* Pickle a bots defaults

* Temporarily enable tests for the v13 branch

* Temporarily enable tests for the v13 branch

* Refactor handling of kwargs in Bot methods (#1924)

* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods

* Refactor JobQueue (#1981)

* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

# Was intended for interal use anyways
# Fixes tests

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue

* Refactor persistence of Bot instances (#1994)

* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation

* Add warning to Updater for passing both defaults and bot

* Address review

* Fix test
@Bibo-Joshi
Add tzinfo to Defaults
4d4aeb2
@Bibo-Joshi Bibo-Joshi added this to the 13.0 milestone Aug 4, 2020
@Bibo-Joshi Bibo-Joshi requested a review from tsnoam August 4, 2020 17:36
@Bibo-Joshi
Rework dtm conversion for classes & some fine tuning
389f95d
@Bibo-Joshi
Temporarily enable tests for the v13 branch
194f36c
@Bibo-Joshi
Refactor handling of kwargs in Bot methods (#1924)
124c93f 
* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods
@Bibo-Joshi
Refactor JobQueue (#1981)
fdc5670 
* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

# Was intended for interal use anyways
# Fixes tests

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue
@Bibo-Joshi
Refactor persistence of Bot instances (#1994)
5a94754 
* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation
@Bibo-Joshi
Extend rich comparison of objects (#1724)
5f84f25 
* Make most objects comparable

* ID attrs for PollAnswer

* fix test_game

* fix test_userprofilephotos

* update for API 4.7

* Warn on meaningless comparisons

* Update for API 4.8

* Address review

* Get started on docs, update Message._id_attrs

* Change PollOption & InputLocation

* Some more changes

* Even more changes
@Bibo-Joshi
Refactor handling of default_quote (#1965)
5ccc1b6 
* Refactor handling of `default_quote`

* Make it a breaking change

* Pickle a bots defaults

* Temporarily enable tests for the v13 branch

* Temporarily enable tests for the v13 branch

* Refactor handling of kwargs in Bot methods (#1924)

* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods

* Refactor JobQueue (#1981)

* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

# Was intended for interal use anyways
# Fixes tests

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue

* Refactor persistence of Bot instances (#1994)

* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation

* Add warning to Updater for passing both defaults and bot

* Address review

* Fix test
@Bibo-Joshi
Refactor Handling of Message VS Update Filters (#2032)
6d3b72a 
* Refactor handling of message vs update filters

* address review
@Bibo-Joshi
Update wording
8b09cf4
@Bibo-Joshi
Let TG-class dates stay in UTC
c0116cd
@Bibo-Joshi
Merge branch 'v13' into default-tz
ba1e685 
# Conflicts:
#	telegram/ext/jobqueue.py
#	telegram/files/venue.py
#	tests/test_jobqueue.py
@Bibo-Joshi
Temporarily enable tests for the v13 branch
dee672d
@Bibo-Joshi
Refactor handling of kwargs in Bot methods (#1924)
02b058c 
* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods
@Bibo-Joshi
Refactor JobQueue (#1981)
958a41e 
* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

# Was intended for interal use anyways
# Fixes tests

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue
@Bibo-Joshi
Refactor persistence of Bot instances (#1994)
c3a426a 
* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation
@Bibo-Joshi
Extend rich comparison of objects (#1724)
fe9370a 
* Make most objects comparable

* ID attrs for PollAnswer

* fix test_game

* fix test_userprofilephotos

* update for API 4.7

* Warn on meaningless comparisons

* Update for API 4.8

* Address review

* Get started on docs, update Message._id_attrs

* Change PollOption & InputLocation

* Some more changes

* Even more changes
@Bibo-Joshi
Refactor handling of default_quote (#1965)
f74be43 
* Refactor handling of `default_quote`

* Make it a breaking change

* Pickle a bots defaults

* Temporarily enable tests for the v13 branch

* Temporarily enable tests for the v13 branch

* Refactor handling of kwargs in Bot methods (#1924)

* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods

* Refactor JobQueue (#1981)

* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

# Was intended for interal use anyways
# Fixes tests

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue

* Refactor persistence of Bot instances (#1994)

* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation

* Add warning to Updater for passing both defaults and bot

* Address review

* Fix test
@Bibo-Joshi
Refactor Handling of Message VS Update Filters (#2032)
87a426e 
* Refactor handling of message vs update filters

* address review
@Bibo-Joshi
Make context-based callbacks the default setting (#2050)
ad30a8f
@Bibo-Joshi
Merge branch 'v13' into default-tz
380f2d6 
# Conflicts:
#	telegram/ext/jobqueue.py
#	tests/test_jobqueue.py
@Bibo-Joshi
Temporarily enable tests for the v13 branch
c3c2934
@Bibo-Joshi Bibo-Joshi force-pushed the v13 branch 2 times, most recently from 1274d26 to be9e5d1 Compare August 24, 2020 18:03
@Bibo-Joshi
Refactor handling of kwargs in Bot methods (#1924)
5f5993b 
* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods
@Bibo-Joshi
Refactor JobQueue (#1981)
f132104 
* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue
@Bibo-Joshi
Refactor persistence of Bot instances (#1994)
7fdd925 
* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation
@Bibo-Joshi
Extend rich comparison of objects (#1724)
4dccf2c 
* Make most objects comparable

* ID attrs for PollAnswer

* fix test_game

* fix test_userprofilephotos

* update for API 4.7

* Warn on meaningless comparisons

* Update for API 4.8

* Address review

* Get started on docs, update Message._id_attrs

* Change PollOption & InputLocation

* Some more changes

* Even more changes
@Bibo-Joshi
Refactor handling of default_quote (#1965)
cfa97b5 
* Refactor handling of `default_quote`

* Make it a breaking change

* Pickle a bots defaults

* Temporarily enable tests for the v13 branch

* Temporarily enable tests for the v13 branch

* Refactor handling of kwargs in Bot methods (#1924)

* Unify kwargs handling in Bot methods

* Remove Request.get, make api_kwargs an explicit argument, move note to head of Bot class

* Fix test_official

* Update get_file methods

* Refactor JobQueue (#1981)

* First go on refactoring JobQueue

* Temporarily enable tests for the v13 branch

* Work on tests

* Temporarily enable tests for the v13 branch

* Increase coverage

* Remove JobQueue.tick()

* Address review

* Temporarily enable tests for the v13 branch

* Address review

* Dispatch errors

* Fix handling of job_kwargs

* Remove possibility to pass a Bot to JobQueue

* Refactor persistence of Bot instances (#1994)

* Refactor persistence of bots

* User BP.set_bot in Dispatcher

* Temporarily enable tests for the v13 branch

* Add documentation

* Add warning to Updater for passing both defaults and bot

* Address review

* Fix test
@Bibo-Joshi
Refactor Handling of Message VS Update Filters (#2032)
eaf0ba7 
* Refactor handling of message vs update filters

* address review
@Bibo-Joshi
Make context-based callbacks the default setting (#2050)
3993250
@Bibo-Joshi
Merge branch 'v13' into default-tz
2dd481b 
# Conflicts:
#	telegram/bot.py
#	telegram/ext/defaults.py
#	telegram/ext/dispatcher.py
#	telegram/ext/filters.py
#	telegram/ext/jobqueue.py
#	telegram/inline/inputlocationmessagecontent.py
#	telegram/message.py
#	telegram/utils/helpers.py
#	tests/test_conversationhandler.py
#	tests/test_jobqueue.py
@Bibo-Joshi
Merge branch 'v13' into default-tz
d686aed 
# Conflicts:
#	telegram/chatmember.py
#	telegram/ext/filters.py
#	telegram/ext/jobqueue.py
#	telegram/files/animation.py
#	telegram/files/document.py
#	telegram/files/file.py
#	telegram/games/game.py
#	tests/test_jobqueue.py
#	tests/test_updater.py
Poolitzer
Poolitzer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Bibo-Joshi Bibo-Joshi merged commit 2859c60 into v13 Sep 27, 2020
@Bibo-Joshi Bibo-Joshi deleted the default-tz branch September 27, 2020 10:59
Bibo-Joshi added a commit that referenced this pull request Sep 27, 2020
@Bibo-Joshi
Defaults.tzinfo (#2042)
3247477
Bibo-Joshi added a commit that referenced this pull request Sep 27, 2020
@Bibo-Joshi
Defaults.tzinfo (#2042)
b7293a4
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2020
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Poolitzer Poolitzer Poolitzer approved these changes

@tsnoam tsnoam Awaiting requested review from tsnoam

Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Bibo-Joshi @Poolitzer