Adjust calling of update_persistence #2285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
Defaults.run_async
when deciding ifupdate_persistence
should be called or not. This was just overlooked by me in Add Defaults.run_async support #2210update_persistence
only once per update and only if the update was handled by at least once sync handler. Having a update handled by multiple groups can slow down the bot significantly otherwise.Also this actually documents how stuff is updated (and fixes the annotation of
process_update
on the fly)