Skip to content

Adjust calling of update_persistence #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Adjust calling of update_persistence #2285

merged 2 commits into from
Jan 7, 2021

Conversation

Bibo-Joshi
Copy link
Member

This does two things:

  • Respect the rather new Defaults.run_async when deciding if update_persistence should be called or not. This was just overlooked by me in Add Defaults.run_async support #2210
  • call update_persistence only once per update and only if the update was handled by at least once sync handler. Having a update handled by multiple groups can slow down the bot significantly otherwise.

Also this actually documents how stuff is updated (and fixes the annotation of process_update on the fly)

(cherry picked from commit 89c522d)
@Bibo-Joshi Bibo-Joshi added this to the v13.2 milestone Jan 1, 2021
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer January 1, 2021 20:51
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit ffd675d into master Jan 7, 2021
@Bibo-Joshi Bibo-Joshi deleted the adjust-persistence branch January 7, 2021 20:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants