Pin cryptography to 3.3.2 #2377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Bibo-Joshi In asyncio branch I've been using httpx which is using cryptography |
|
@tsnoam Only for the tests apparently: https://github.com/encode/httpx/blob/master/requirements.txt#L19 |
|
@Bibo-Joshi Interesting. How do they perform Need to check. |
|
uh. using the standard ok. |
|
Closing in favor of #2386 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2372
I propose to leave #2372 open and give the cryptography time to figure out their plans for the future. As we need cryptography only for passports (and I've never met anyone acutally using those …) it's not a main security issue. Nevertheless I subscribed to the cryptography release channel to keep an eye on the changelog for security fixes.
If the situation is more clear in the future we can think about how we want to approach the issue.