proposed fix for #2542: proper treatment of pooled_function exception… #2543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_function exceptions in Promise send the pooled_function exception back through done_callback instead of eating it up, mistreating it as a done_callback exception
|
hey Glad to see that you are eager to fix this. However, your change is immediately breaking (especially for
You can also just add proper error handling directly in your
Moreover, If you want to, you are very welcome to update your PR to the approach detailed in #2542 (comment) :) |
|
superseded by #2544. Nevertheless, thanks for taking the time to PR :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send the pooled_function exception back through done_callback instead of eating it up, mistreating it as a done_callback exception