Fix method signatures and expand test_official
#2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update type hint: Any -> object
Removed __hash__ of VoiceChatParticipantsInvited. Also more Any->object
didn't commit that weird
Bibo-Joshi
reviewed
Aug 27, 2021
There was a problem hiding this comment.
Nice PR! Regarding your notes:
- If you like to, you can remove the ChatMember args & attributes here already. Deprecation: v14 #2346 was split up into mutliple PRs by now anyway. IISC that should also simplify your helper routines for
test_chatmembera bit. - What exactly is your question about
ChatMember.de_json? IISC you only changed the tests, not the actual implementation - I left a note about
VCPI.__hash__:)
Yes, I didn't change the implementation per se. I just wanted to confirm that |
Also removed unused code and improved a few things
Bibo-Joshi
reviewed
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2367
Notes:
ChatMemberyet as that's part of Deprecation: v14 #2346. But it's been effectively removed. (Edit: now removed.)__hash__()ofVoiceChatParticipantsInvitedsince its attribute is actually optional. (Edit: added it back)de_jsonofChatMember*correctly?Tests:
test_officialnow scans if argument if required or not.