Skip to content

Conversation

Bibo-Joshi
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests

@Bibo-Joshi Bibo-Joshi added the 🛠 breaking change type: breaking label Aug 29, 2021
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Aug 29, 2021
@Bibo-Joshi Bibo-Joshi mentioned this pull request Aug 29, 2021
22 tasks
Copy link
Member

@starry-shivam starry-shivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good to me.

@Bibo-Joshi Bibo-Joshi merged commit a5340e3 into v14 Aug 30, 2021
@Bibo-Joshi Bibo-Joshi deleted the deprecation branch August 30, 2021 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 breaking change type: breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants