Skip to content

Conversation

harshil21
Copy link
Member

If users don't input the keyboard in the correct format, i.e a list of lists, then the resulting error is hard to debug and its not obvious what went wrong.

inspired from #2652

@harshil21 harshil21 added this to the v14 milestone Sep 14, 2021
Resolved issues in telegram/replymarkup.py via DeepSource Autofix
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

can you call check_keyboard_type either at the end of __init__ for both or at the start of __init__ for both?

@Bibo-Joshi Bibo-Joshi merged commit c2f8ac0 into v14 Sep 15, 2021
@Bibo-Joshi Bibo-Joshi deleted the check-kb-type branch September 15, 2021 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔌 enhancement pr description: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants