Skip to content

Move error_handler error handing into Dispatcher.dispatch_error #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2021
Merged

Move error_handler error handing into Dispatcher.dispatch_error #2660

merged 5 commits into from
Sep 17, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Sep 15, 2021 •
edited
Loading

closes #2601

replacement for #2649

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests

@Bibo-Joshi Bibo-Joshi added enhancement 🛠 refactor change type: refactor labels Sep 15, 2021
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Sep 15, 2021
@Bibo-Joshi Bibo-Joshi mentioned this pull request Sep 15, 2021
Closed
2 tasks
github-actions[bot]
github-actions bot reviewed Sep 15, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

harshil21
harshil21 requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 2 nitpicks because the changes are good!

Bibo-Joshi and others added 2 commits September 16, 2021 17:54
@Bibo-Joshi @harshil21
wording
36a777d 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Address review
6ad636f
@Bibo-Joshi Bibo-Joshi merged commit 8ac65fc into v14 Sep 17, 2021
@Bibo-Joshi Bibo-Joshi deleted the error-handling-v2 branch September 17, 2021 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement 🛠 refactor change type: refactor
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
2 participants
@Bibo-Joshi @harshil21