Warnings overhaul #2662
Merged
Warnings overhaul #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
Sep 16, 2021
There was a problem hiding this comment.
Looks good so far! Comments:
- Even if import policy is changed in #2468, we should probably rename
utils.deprecatetoutils.warningsalready since that file is now no longer exclusively for deprecation - Just a thought: Maybe it's worth adding a function
utils.warnings.warn, which acts as a shortcut forwarnings.warnwith a defaultcategory=TelegramUserWarning? - Another thought: Maybe
PTB*Warningis better thanTG*Warningb/c the warnings are issued by PTB and not by TG?
Bibo-Joshi
reviewed
Sep 19, 2021
Bibo-Joshi
reviewed
Sep 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2467
Notes:
Made
Telegram{User, Deprecation}Warningpublic and is accessible bytelegram.utils.deprecate. We can change it later depending on Clear up imports policy #2468. Edit: Review now made it accessible viatelegram.utils.warningssome warnings don't have stacklevels because they take place in another thread so its not possible to get the caller
update some warning messages to be more descriptive.