Skip to content

fix @log annotation for pycharm and vscode #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 3, 2021
Merged

fix @log annotation for pycharm and vscode #2686

merged 5 commits into from
Oct 3, 2021

Conversation

harshil21
Copy link
Member

@harshil21 harshil21 commented Oct 1, 2021 •
edited
Loading

Closes #2677.
Also adds a test for checking @log

@harshil21 harshil21 added this to the v14 milestone Oct 1, 2021
@harshil21 harshil21 mentioned this pull request Oct 1, 2021
Closed
Bibo-Joshi
Bibo-Joshi reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test that actually checks that @log works?

@Bibo-Joshi Bibo-Joshi added the 📋 pending-reply work status: pending-reply label Oct 1, 2021
@harshil21
Copy link
Member Author

harshil21 commented Oct 1, 2021 •
edited
Loading

do we have a test that actually checks that @log works?

I can't find one. I'll add it.

Bibo-Joshi
Bibo-Joshi reviewed Oct 1, 2021
View reviewed changes
@harshil21 harshil21 removed the 📋 pending-reply work status: pending-reply label Oct 3, 2021
@Bibo-Joshi Bibo-Joshi merged commit b79487d into v14 Oct 3, 2021
@Bibo-Joshi Bibo-Joshi deleted the fix-log-type-hints branch October 3, 2021 18:06
Bibo-Joshi pushed a commit that referenced this pull request Oct 3, 2021
@harshil21 @Bibo-Joshi
Improve Signature Inspection for Bot Methods (#2686)
2c44dc0
@harshil21 harshil21 mentioned this pull request Oct 4, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 bug pr description: bug and removed bug 🐛 labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

Assignees
No one assigned
Labels
🔌 bug pr description: bug
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil21 @Bibo-Joshi