Skip to content

changing notifier event trigger #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2021
Merged

changing notifier event trigger #2695

merged 1 commit into from
Oct 3, 2021

Conversation

Poolitzer
Copy link
Member

@Poolitzer Poolitzer commented Oct 3, 2021 •
edited
Loading

This changes the trigger to the new *_target one, which gives the forks enough rights to comment in their PR.

I tested the changes on my fork, just for the example notifier, but since the code is the same for each workflow, this should be enough.

@Bibo-Joshi Bibo-Joshi merged commit efb4904 into v14 Oct 3, 2021
@Bibo-Joshi Bibo-Joshi deleted the notifier-target-fixes branch October 3, 2021 13:38
Bibo-Joshi pushed a commit that referenced this pull request Oct 3, 2021
@Poolitzer @Bibo-Joshi
Update Notification Workflows (#2695)
b0385c1
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Poolitzer @Bibo-Joshi