Skip to content

Add generic 'edited' update filter #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2021
Merged

Add generic 'edited' update filter #2705

merged 2 commits into from
Oct 7, 2021

Conversation

PhilippFr
Copy link
Contributor

@PhilippFr PhilippFr commented Oct 6, 2021 •
edited
Loading

Added a filter Filters.update.edited working for both messages and channel posts.

Closes #2703

@PhilippFr
Add generic 'edited' update filter
9b79333 
Added a filter Filters.update.edited working for both messages and channel posts.

Closes python-telegram-bot#2703
@Bibo-Joshi Bibo-Joshi changed the base branch from master to v14 October 6, 2021 15:08
Bibo-Joshi
Bibo-Joshi requested changes Oct 6, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! The new filter itself looks good :) However, we will need both documentation & tests for the new functionality (the PR template is there for a reason 😉 ). The documentation is just a few lines below your changes, you can add the new filter there. For the tests, please have a look at the file tests/test_filters.py and add a new test - you can copy & adapt the existing tests for Filters.update.*. The contribution guide also has a number of details on bulding the docs and running the tests ;)

@harshil21 harshil21 added this to the v14 milestone Oct 6, 2021
@PhilippFr
Copy link
Contributor Author

Thanks for the quick PR! The new filter itself looks good :) However, we will need both documentation & tests for the new functionality (the PR template is there for a reason 😉 ). The documentation is just a few lines below your changes, you can add the new filter there. For the tests, please have a look at the file tests/test_filters.py and add a new test - you can copy & adapt the existing tests for Filters.update.*. The contribution guide also has a number of details on bulding the docs and running the tests ;)

Thank you for the feedback, im on it 😃

@PhilippFr
Add tests and documentation
8f61e73 
Added `Filters.update.edited` to tests and documentation.
@PhilippFr PhilippFr requested a review from Bibo-Joshi October 7, 2021 11:55
Bibo-Joshi
Bibo-Joshi approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 I'll ask for a second review from the dev team and then we can merge

@Bibo-Joshi Bibo-Joshi merged commit 13433e3 into python-telegram-bot:v14 Oct 7, 2021
@Bibo-Joshi
Copy link
Member

Thank you for the contribution @PhilippFr !

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
@harshil21 harshil21 added the hacktoberfest-accepted other: hacktoberfest-accepted label Oct 30, 2021
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

@harshil21 harshil21 harshil21 approved these changes

@Poolitzer Poolitzer Awaiting requested review from Poolitzer

Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement hacktoberfest-accepted other: hacktoberfest-accepted
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Filters.update.edited
3 participants
@PhilippFr @Bibo-Joshi @harshil21