Skip to content

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Oct 20, 2021

Just stumbled on this. JobQueue.put seems to be gone since some 5 years … Anyway, if you have access to a job, then you also have access to either the JobQueue directly or at least a CallbackContext instance, which already contains the job_queue, so IMO there is no need to keep this double reference alive (job_queue contains job, contains job_queue)

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests

Breaking changes:

  • the title

@Bibo-Joshi Bibo-Joshi added the 🛠 breaking change type: breaking label Oct 20, 2021
@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Oct 20, 2021
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer October 20, 2021 18:54
@Bibo-Joshi Bibo-Joshi added the 📋 pending-review work status: pending-review label Oct 21, 2021
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did miss that one, change looks good.

@Bibo-Joshi Bibo-Joshi merged commit 8f4105d into v14 Oct 21, 2021
@Bibo-Joshi Bibo-Joshi deleted the remove-job.job_queue branch October 21, 2021 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 breaking change type: breaking 📋 pending-review work status: pending-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants